[webkit-reviews] review granted: [Bug 74549] Web Inspector: Switch to type-safe JSON ConsoleMessage.cpp, InspectorDOMAgent.cpp, InspectorDebuggerAgent.cpp, ScriptCallFrame.cpp : [Attachment 119311] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Peter Rybin
<peter.rybin at gmail.com>'s request for review:
Bug 74549: Web Inspector: Switch to type-safe JSON ConsoleMessage.cpp,
InspectorDOMAgent.cpp, InspectorDebuggerAgent.cpp, ScriptCallFrame.cpp
https://bugs.webkit.org/show_bug.cgi?id=74549

Attachment 119311: Patch
https://bugs.webkit.org/attachment.cgi?id=119311&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119311&action=review


Great job!

> Source/WebCore/inspector/ScriptCallFrame.cpp:67
> +	       String::number(m_lineNumber))

Please do a drive-by fix to the protocol itself instead of this workaround. You
can also fix the Inspector-0.1.json in this case - it is clearly a typo.