[webkit-reviews] review granted: [Bug 74391] Web Inspector: make ProfilesPanel scale as the number of ProfileTypes grows : [Attachment 119227] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 74391: Web Inspector: make ProfilesPanel scale as the number of
ProfileTypes grows
https://bugs.webkit.org/show_bug.cgi?id=74391

Attachment 119227: Patch
https://bugs.webkit.org/attachment.cgi?id=119227&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119227&action=review


> Source/WebCore/inspector/front-end/ProfilesPanel.js:506
> +    updateProfileTypeButtons: function(isProfiling, effectButton)

Please annotate this using jsdoc.

> Source/WebCore/inspector/front-end/ProfilesPanel.js:759
> +		  
this._profileTypeButtonsByIdMap[typeId].element.removeStyleClass("hidden");

this._profileTypeButtonsByIdMap[typeId].visible = true;

> Source/WebCore/inspector/front-end/ProfilesPanel.js:767
> +		  
this._profileTypeButtonsByIdMap[typeId].element.addStyleClass("hidden");

this._profileTypeButtonsByIdMap[typeId].visible = false;