[webkit-reviews] review denied: [Bug 74510] Add ENABLE(HARMONY) and --harmony : [Attachment 119232] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Andy Wingo
<wingo at igalia.com>'s request for review:
Bug 74510: Add ENABLE(HARMONY) and --harmony
https://bugs.webkit.org/show_bug.cgi?id=74510

Attachment 119232: Patch
https://bugs.webkit.org/attachment.cgi?id=119232&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I'm not sure that this makes sense as a global setting.  Some scripts may be
harmonious, others not, so we're going to need harmony to be enabled on a
source-by-source basis, not as a global option.  I don't think a 'harmony' flag
in the JSC framework is needed.  The command shell may want to look for this
flag as an instruction as to how the source it reads in should be interpreted -
to create SourceCode/SourceProvider objects with an ES6 flag set (perhaps this
should be a new default-to-false argument to makeSource).

I don't know what you'd do with a harmonyBlockScoping global setting - for ES5
scripts it only makes sense to not use harmony scoping rules, for ES6 scripts
it only makes sense to do so.

We generally don't accept changes that are not complete in their own right, and
are effectively dead code - which this is.  Whilst we do like to see changes
broken down into smaller patches where sensible, I'd suggest that this is a
small enough change that it may be wiser to introduce this alongside the first
actual harmony feature implemented.