[webkit-reviews] review granted: [Bug 68479] Hardware acceleration of W3C Filter Effects : [Attachment 119345] Patch to move FilterOperation(s) to platform/graphics

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 68479: Hardware acceleration of W3C Filter Effects
https://bugs.webkit.org/show_bug.cgi?id=68479

Attachment 119345: Patch to move FilterOperation(s) to platform/graphics
https://bugs.webkit.org/attachment.cgi?id=119345&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119345&action=review


> Source/WebCore/ChangeLog:8
> +	   Move FilterOperation(s) to platform/graphics/filters so it can be
used to pass filter spec down

filter spec -> filter details?

> Source/WebCore/ChangeLog:12
> +	   eventually need to be down in platform. But until we have a hardware
accelerated version of 
> +	   CSS Shaders that can wait.

I think you can remove the last sentence.

> Source/WebCore/platform/graphics/GraphicsLayer.h:313
> -
> +    

Unrelated change.