[webkit-reviews] review granted: [Bug 74292] Web Inspector: [Styles] Update selected DOM element styles whenever applicable media queries change : [Attachment 119237] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 74292: Web Inspector: [Styles] Update selected DOM element styles whenever
applicable media queries change
https://bugs.webkit.org/show_bug.cgi?id=74292

Attachment 119237: Patch
https://bugs.webkit.org/attachment.cgi?id=119237&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119237&action=review


> Source/WebCore/inspector/InspectorCSSAgent.cpp:197
> +    , m_enabled(false)

you don't actually need to mimic the m_state->get(cssAgentEnabled) state.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:216
> +    m_instrumentingAgents->setInspectorCSSAgent(this);

Can we do it even later? Like in enable?

> Source/WebCore/page/FrameView.cpp:1005
> +	       InspectorInstrumentation::didMediaQueryResultChange(document);

We only use did* notation when there is a corresponding will* signal.
::mediaQueryResultChanged would be Ok in this case.