[webkit-reviews] review granted: [Bug 74188] Web Inspector: Generated HAR is missing pages.startedDateTime : [Attachment 119236] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 15:30:40 PST 2011

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 74188: Web Inspector: Generated HAR is missing pages.startedDateTime

Attachment 119236: Patch

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119236&action=review

> LayoutTests/http/tests/inspector/inspector-test.js:112
> +InspectorTest.formatAsTypeName = function(value)

I don't think firnatters should be defined on the InspectorTest object - use a
nested object / namespace instead.

> LayoutTests/http/tests/inspector/inspector-test.js:135
> +	   if (customFormatters && typeof customFormatters[prop] === "string")

Why do we have this distinction now that there is a default formatting?

More information about the webkit-reviews mailing list