[webkit-reviews] review granted: [Bug 74542] Implement flexDirection and flexWrap and make flexFlow a proper shorthand. : [Attachment 119302] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 74542: Implement flexDirection and flexWrap and make flexFlow a proper
shorthand.
https://bugs.webkit.org/show_bug.cgi?id=74542

Attachment 119302: Patch
https://bugs.webkit.org/attachment.cgi?id=119302&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119302&action=review


Maybe add a test case that sets (direction|wrap) and flow and the last one set
wins.

> LayoutTests/css3/flexbox/script-tests/css-properties.js:154
> +    shouldBeEqualToString('flexbox.style.webkitFlexFlow',
(expected).replace(/^ /, '').replace(/ $/, ''));

Nit: Remove () around expected.