[webkit-reviews] review granted: [Bug 74533] REGRESSION(r102619): Reproducible crash closing window with video + poster image inside an object element : [Attachment 119297] Patch v2 - Style fix and better layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 14:32:14 PST 2011


Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 74533: REGRESSION(r102619): Reproducible crash closing window with video +
poster image inside an object element
https://bugs.webkit.org/show_bug.cgi?id=74533

Attachment 119297: Patch v2 - Style fix and better layout test
https://bugs.webkit.org/attachment.cgi?id=119297&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119297&action=review


> Source/WebCore/html/HTMLPlugInImageElement.h:59
> +    virtual bool canSuspend() const OVERRIDE;
> +    virtual void suspend(ReasonForSuspension) OVERRIDE;
> +    virtual void resume() OVERRIDE;

Do these need to be public? Why can’t they be protected?


More information about the webkit-reviews mailing list