[webkit-reviews] review granted: [Bug 73926] [chromium] Race condition in CCLayerTreeHostTest shutdown : [Attachment 119199] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 11:58:42 PST 2011


James Robinson <jamesr at chromium.org> has granted Sami Kyostila
<skyostil at google.com>'s request for review:
Bug 73926: [chromium] Race condition in CCLayerTreeHostTest shutdown
https://bugs.webkit.org/show_bug.cgi?id=73926

Attachment 119199: Patch
https://bugs.webkit.org/attachment.cgi?id=119199&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I'm biased, but I prefer the way I wrote this in
https://bugs.webkit.org/attachment.cgi?id=119042&action=review (search for
"runTaskIfNotShutdown") for a few minor reasons (we prefer early outs, it's
better to take ownership of a PassOwnPtr<> ASAP, this is a bit non-obvious and
deserves a comment). This does look correct, however. At the very least please
add a comment the rest is up to you.


More information about the webkit-reviews mailing list