[webkit-reviews] review granted: [Bug 74428] Create reftest for outline-sides-in-region : [Attachment 119080] reftest, removals, plus test enablement for chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 11:00:43 PST 2011

Darin Adler <darin at apple.com> has granted Ethan Malasky <emalasky at adobe.com>'s
request for review:
Bug 74428: Create reftest for outline-sides-in-region

Attachment 119080: reftest, removals, plus test enablement for chromium

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119080&action=review

> LayoutTests/fast/regions/outline-sides-in-region-expected.html:15
> +	<div id="region">
> +		<div id="source">

I suggest omitting the ids.

> LayoutTests/fast/regions/outline-sides-in-region.html:10
> +	/* There appears to be a bug in margin-top collapsing for the first
> +	 That issue will be filed separately. For now, forcing margin-top:0
allows us
> +	to create an accurate reftest for outline drawing. */

Strange indentation here. Also, we normally use // comments rather than /*

More information about the webkit-reviews mailing list