[webkit-reviews] review granted: [Bug 74370] Hardware-backed renderLayer could avoid repainting during a positioned movement layout : [Attachment 119222] Added more testing following Simon's cue, a passing test is worth 1000 words.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 74370: Hardware-backed renderLayer could avoid repainting during a
positioned movement layout
https://bugs.webkit.org/show_bug.cgi?id=74370

Attachment 119222: Added more testing following Simon's cue, a passing test is
worth 1000 words.
https://bugs.webkit.org/attachment.cgi?id=119222&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119222&action=review


> Source/WebCore/rendering/RenderLayer.h:79
> +    RepaintAfterLayout = 0,
> +    NeedsFullRepaint = 1,
> +    NeedsFullRepaintForPositionedMovementLayout = 1 << 1,

These values are slightly confusing. Maybe it's not used, but "no repaint
needed" would be a sensible 0 value, with the other values all non-zero.

I also find 1 << 0, 1, << 1 a bit more consistent.

> Source/WebCore/rendering/RenderLayer.h:751
> +    RepaintStatus m_repaintStatus : 2;

I think we normally stuff enums into unsigned bitfield fields, for Windows?