[webkit-reviews] review granted: [Bug 74415] [skia] cache typeface in FontPlatformData : [Attachment 119027] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 08:15:31 PST 2011

Stephen White <senorblanco at chromium.org> has granted Mike Reed
<reed at google.com>'s request for review:
Bug 74415: [skia] cache typeface in FontPlatformData

Attachment 119027: Patch

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119027&action=review

Looks good.  r=me

> Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:439
> +	   paintSkiaText(graphicsContext, font->platformData(), curLen,
&glyphs[0], &advances[0], 0, &origin);

Nit:  Looks like you can get rid of the hfont local var now.

> Source/WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.h:85
> +	       value ^= m_typeface->uniqueID();

Is there a possibility for hash collisions if both font and typeface are

More information about the webkit-reviews mailing list