[webkit-reviews] review granted: [Bug 74426] [Qt] [Gardening] Remove qt-4.7 layout tests dir : [Attachment 119196] Remove qt-4.7 layout tests dir

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 04:43:07 PST 2011


Csaba Osztrogonac <ossy at webkit.org> has granted João Paulo Rechi Vita
<jprvita at openbossa.org>'s request for review:
Bug 74426: [Qt]  [Gardening] Remove qt-4.7 layout tests dir
https://bugs.webkit.org/show_bug.cgi?id=74426

Attachment 119196: Remove qt-4.7 layout tests dir
https://bugs.webkit.org/attachment.cgi?id=119196&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119196&action=review


r=me with a little change. I'll land it manually.

> Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:-74
> -	   self._assert_search_path(['qt-mac', 'qt-4.8', 'qt'], 'darwin',
qt_version='4.8')
> -	   self._assert_search_path(['qt-win', 'qt-4.8', 'qt'], 'win32',
qt_version='4.8')
> -	   self._assert_search_path(['qt-win', 'qt-4.8', 'qt'], 'cygwin',
qt_version='4.8')
> -	   self._assert_search_path(['qt-linux', 'qt-4.8', 'qt'], 'linux2',
qt_version='4.8')
> -	   self._assert_search_path(['qt-linux', 'qt-4.8', 'qt'], 'linux3',
qt_version='4.8')

We need these lines too.


More information about the webkit-reviews mailing list