[webkit-reviews] review denied: [Bug 74426] [Qt] [Gardening] Remove qt-4.7 layout tests dir : [Attachment 119070] Remove qt-4.7 layout tests dir

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 22:56:54 PST 2011

Csaba Osztrogonac <ossy at webkit.org> has denied João Paulo Rechi Vita
<jprvita at openbossa.org>'s request for review:
Bug 74426: [Qt]  [Gardening] Remove qt-4.7 layout tests dir

Attachment 119070: Remove qt-4.7 layout tests dir

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119070&action=review

> Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:-68
> -	   self._assert_search_path(['qt-mac', 'qt-4.7', 'qt'], 'darwin')
> -	   self._assert_search_path(['qt-win', 'qt-4.7', 'qt'], 'win32')
> -	   self._assert_search_path(['qt-win', 'qt-4.7', 'qt'], 'cygwin')
> -	   self._assert_search_path(['qt-linux', 'qt-4.7', 'qt'], 'linux2')
> -	   self._assert_search_path(['qt-linux', 'qt-4.7', 'qt'], 'linux3')

These lines shouldn't be removed, because we should check the 
default qt_version too, which became '4.8' with this patch.
So please change qt-4.7 to qt-4.8, and I'll r+ the patch,
and land it manually, because svn-apply doesn't like
removed files in a patch.

More information about the webkit-reviews mailing list