[webkit-reviews] review denied: [Bug 73926] [chromium] Race condition in CCLayerTreeHostTest shutdown : [Attachment 118059] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 21:12:27 PST 2011

James Robinson <jamesr at chromium.org> has denied Sami Kyostila
<skyostil at google.com>'s request for review:
Bug 73926: [chromium] Race condition in CCLayerTreeHostTest shutdown

Attachment 118059: Patch

------- Additional Comments from James Robinson <jamesr at chromium.org>
Ah, I think the fix is much simpler - check the m_shutdown flag in
CCScopedThreadProxy::runTaskIfNotShutdown() before touching the m_targetThread.
I had to do this for another patch anyway for a similar issue.	I don't really
like the idea of moving around the RunAllPendingMessages() thing here, since
you'll have the same potential issue with the m_timeoutTask.

More information about the webkit-reviews mailing list