[webkit-reviews] review denied: [Bug 74270] [Forms] Default selection of select(menulist) should not be default : [Attachment 119142] Patch 6
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 13 20:24:24 PST 2011
Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 74270: [Forms] Default selection of select(menulist) should not be default
https://bugs.webkit.org/show_bug.cgi?id=74270
Attachment 119142: Patch 6
https://bugs.webkit.org/attachment.cgi?id=119142&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119142&action=review
> Source/WebCore/ChangeLog:616
>
> + [Forms] Disabled option selected in form
> + https://bugs.webkit.org/show_bug.cgi?id=74270
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + Ignore and deselect disabled option element during computing
> + default select option.
> +
> + Tests: fast/forms/select/menulist-disabled-option-expected.html
> + fast/forms/select/menulist-disabled-option.html
> +
> + * html/HTMLSelectElement.cpp:
> + (WebCore::HTMLSelectElement::recalcListItems): Checks option element
is disabled or not.
> +
> +2011-12-13 Yosifumi Inoue <yosin at chromium.org>
> +
> RenderTheme should have a function for disabled text color
adjustment
This contains two new ChangeLog entries.
More information about the webkit-reviews
mailing list