[webkit-reviews] review granted: [Bug 74389] [Refactoring] Remove several global variables from prepare-ChangeLog : [Attachment 118974] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 74389: [Refactoring] Remove several global variables from prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=74389

Attachment 118974: Patch
https://bugs.webkit.org/attachment.cgi?id=118974&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118974&action=review


r=me

> Tools/Scripts/prepare-ChangeLog:176
> -my $addedRegressionTests = generateFileList(@changedFiles, @conflictFiles,
%functionLists);
> +my ($changedFiles, $conflictFiles, $functionLists, $addedRegressionTests) =
generateFileList(%paths);

In the future, it seems like we should try to come up with a data structure to
hold this data instead of passing a list of variables back.

This is okay for now, though.