[webkit-reviews] review granted: [Bug 73852] Expose reusable WebSocket code for WebSocketServer. : [Attachment 119061] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 18:12:42 PST 2011


Kent Tamura <tkent at chromium.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 73852: Expose reusable WebSocket code for WebSocketServer.
https://bugs.webkit.org/show_bug.cgi?id=73852

Attachment 119061: Patch
https://bugs.webkit.org/attachment.cgi?id=119061&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119061&action=review


> Source/WebCore/websockets/WebSocketChannel.cpp:629
> -	   fail("One or more reserved bits are on: reserved1 = " +
String::number(frame.reserved1) + ", reserved2 = " +
String::number(frame.reserved2) + ", reserved3 = " +
String::number(frame.reserved3));
> +    if (frame.options & (FrameOptionReserved1 | FrameOptionReserved2 |
FrameOptionReserved3)) {
> +	   fail("One or more reserved bits are on: reserved1 = " +
String::number(!!(frame.options & FrameOptionReserved1)) + ", reserved2 = " +
String::number(!!(frame.options & FrameOptionReserved2)) + ", reserved3 = " +
String::number(!!(frame.options & FrameOptionReserved3)));

nit: We have String::format().


More information about the webkit-reviews mailing list