[webkit-reviews] review granted: [Bug 71181] Layout Test fast/forms/input-step-as-double.html fails after running touch event tests : [Attachment 118983] Patch 2

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 71181: Layout Test fast/forms/input-step-as-double.html fails after running
touch event tests
https://bugs.webkit.org/show_bug.cgi?id=71181

Attachment 118983: Patch 2
https://bugs.webkit.org/attachment.cgi?id=118983&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118983&action=review


> Source/WebCore/ChangeLog:13
> +	   before a mousemove event in the element. It is not true for touch
> +	   events.
> +	   We should not reset m_upDownState to Indetermiante in
> +	   setHovered(true), and should reset it when the mouse pointer moves
> +	   out.

It's really unpleasant to see "events." and "out." wrapped awkwardly like this.
Please fix it before landing it.
While we don't mandate the number of colums to be included in each line, I
think readability and cleanness of code, comment, and changelog are very
important.