[webkit-reviews] review requested: [Bug 74352] [skia] Track a simple opaque area when painting via PlatformContextSkia and save in LayerTextureUpdater : [Attachment 119103] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 16:15:57 PST 2011


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 74352: [skia] Track a simple opaque area when painting via
PlatformContextSkia and save in LayerTextureUpdater
https://bugs.webkit.org/show_bug.cgi?id=74352

Attachment 119103: Patch
https://bugs.webkit.org/attachment.cgi?id=119103&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
A new patch addressing concerns and ideas voiced here and on chats; thanks for
the good feedback.

Simplied the decision/storage of the opaque region by just storing a Rect. Try
to expand the rect when possible, or replace it when seeing a larger rect.

Considers gradients (and checks if they have alpha) and patterns (assumes they
have alpha).


More information about the webkit-reviews mailing list