[webkit-reviews] review denied: [Bug 74456] [V8][Chromium] Reenable dedicated worker layout tests : [Attachment 119100] Fix

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Dmitry Lomov <dslomov at google.com>'s
request for review:
Bug 74456: [V8][Chromium] Reenable dedicated worker layout tests
https://bugs.webkit.org/show_bug.cgi?id=74456

Attachment 119100: Fix
https://bugs.webkit.org/attachment.cgi?id=119100&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119100&action=review


> LayoutTests/ChangeLog:11
> +	   * platform/chromium/fast/workers/worker-script-error-expected.txt:
Added.

It would be great to explain why we have Chromium specific results (in the
ChangeLog).

> LayoutTests/platform/chromium/test_expectations.txt:157
> +WONTFIX SKIP : fast/workers/worker-crash-with-invalid-location.html = TEXT

I don't understand this last line.

> LayoutTests/platform/chromium/test_expectations.txt:165
> +WONTFIX SKIP : fast/workers/worker-multi-port.html = CRASH

Odd that we crash when we don't support it. That doesn't seem great.

> LayoutTests/platform/chromium/test_expectations.txt:169
> +

extra blank line.