[webkit-reviews] review denied: [Bug 74221] Web Inspector: consider disabling network tracking while running the CPU profile : [Attachment 119010] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 13:19:03 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 74221: Web Inspector: consider disabling network tracking while running the
CPU profile
https://bugs.webkit.org/show_bug.cgi?id=74221

Attachment 119010: Patch
https://bugs.webkit.org/attachment.cgi?id=119010&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119010&action=review


> Source/WebCore/ChangeLog:6
> +	   User report:

ChangeLog should not include all the bug report details. It should rather be a
summary of the changes performed.

> Source/WebCore/inspector/front-end/NetworkManager.js:42
> +    this._resourceTrackingRequestSent = false;

this._resourceTracking should be sufficient.


More information about the webkit-reviews mailing list