[webkit-reviews] review denied: [Bug 74381] Upstream 3 files into WebCore/platform/blackberry : [Attachment 118958] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Mary Wu <mary.wu at torchmobile.com.cn>'s
request for review:
Bug 74381: Upstream 3 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74381

Attachment 118958: Patch
https://bugs.webkit.org/attachment.cgi?id=118958&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118958&action=review


Looks very good, can be cleaned up a bit more I think.

> Source/WebCore/platform/blackberry/ClipboardBlackBerry.cpp:2
> + * Copyright (C) 2010 Research In Motion Limited. All rights reserved.

This was touched in 2011, may as well update that fact.

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:2
> + * Copyright (C) 2009 Research In Motion Limited. All rights reserved.

This was touched in 2011, may as well update that fact.

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:91
> +    String html =
String::fromUTF8(BlackBerry::Platform::Clipboard::readHTML().c_str());

RefPtr<DocumentFragment> fragment could be declared here.

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:96
> +	   if (fragment)

Can write this like if (fragment = createFragmentFromMarkup(frame->document(),
html, url, FragmentScriptingNotAllowed))

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:106
> +    if (fragment) {

Can write this like if (fragment = createFragmentFromText(context.get(), text))