[webkit-reviews] review denied: [Bug 74430] watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it. : [Attachment 119055] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 12:53:05 PST 2011


David Levin <levin at chromium.org> has denied Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 74430: watchlist: Add watchlist for EFL, CMake and libsoup code and put
myself on it.
https://bugs.webkit.org/show_bug.cgi?id=74430

Attachment 119055: Patch
https://bugs.webkit.org/attachment.cgi?id=119055&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119055&action=review


>>> Tools/Scripts/webkitpy/common/config/watchlist:123
>>> +		 "more": r"CMakeLists.*\.txt"
>> 
>> Did you mean more here? That would mean that a file contains more references
to this regex than it did before.
> 
> Not really; the wiki page is a bit unclear about this. I had tried filename
before, but my regex was probably wrong.

Sorry. I welcome any hints about clarifications or if you could explain what
you thought it said, I can try to reword it.

The more/less support is for matching within files. (For example, I use it to
alert me about new uses of threading structures.)


More information about the webkit-reviews mailing list