[webkit-reviews] review granted: [Bug 74423] [MutationObservers] Avoid allocations if no observers are present : [Attachment 119043] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Rafael Weinstein
<rafaelw at chromium.org>'s request for review:
Bug 74423: [MutationObservers] Avoid allocations if no observers are present
https://bugs.webkit.org/show_bug.cgi?id=74423

Attachment 119043: Patch
https://bugs.webkit.org/attachment.cgi?id=119043&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119043&action=review


Feel free to committ after addressing Adam's and my feedback

> Source/WebCore/dom/WebKitMutationObserver.cpp:167
> +    return createIfNeeded(target, WebKitMutationObserver::ChildList,
nullAtom, 0 /* oldValueFlag */);

The typical webkit way of doing this is to create a local oldValueFlag variable
instead of adding a comment.