[webkit-reviews] review granted: [Bug 74228] Implement GLES2 CheckFramebufferStatus() behavior : [Attachment 119029] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 10:36:54 PST 2011


Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 74228: Implement GLES2 CheckFramebufferStatus() behavior
https://bugs.webkit.org/show_bug.cgi?id=74228

Attachment 119029: Patch
https://bugs.webkit.org/attachment.cgi?id=119029&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119029&action=review


Looks good overall. Couple of minor issues with the ChangeLog that can be fixed
upon landing. Please make sure it passes the EWS bots before committing.

> Source/WebCore/ChangeLog:6
> +	   * html/canvas/WebGLFramebuffer.cpp:

Missing the "Reviewed by" line.

> LayoutTests/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=74228

Missing "Reviewed by" line.


More information about the webkit-reviews mailing list