[webkit-reviews] review canceled: [Bug 61338] Element not fully repainted after application and removal of transform : [Attachment 118963] proposed patch along with the test case for the "Element not fully repainted after application and removal of transform"

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Vamshi Krishna N
<vnampally at innominds.com>'s request for review:
Bug 61338: Element not fully repainted after application and removal of
transform
https://bugs.webkit.org/show_bug.cgi?id=61338

Attachment 118963: proposed patch along with the test case for the "Element not
fully repainted after application and removal of transform"
https://bugs.webkit.org/attachment.cgi?id=118963&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118963&action=review


It looks like your patch is confusing our tools. Could you rebaseline the patch
on WebKit trunk and use "Tools/Scripts/webkit-patch upload" (webkit-patch help
upload is your friend) to submit the rebaselined patch.

> Source/WebCore/rendering/RenderObject.cpp:1689
> +	       if (!hasLayer() || diff == StyleDifferenceEqual)

I still think RenderStyle::diff could handle that more cleanly and I haven't
seen a reply from you on that (see comment #3 about the #if AC).