[webkit-reviews] review requested: [Bug 72893] [Qt][WK2] Add (experimental) viewport attributes view to MiniBrowser/qt : [Attachment 119018] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 07:52:30 PST 2011


Michael Brüning <michael.bruning at nokia.com> has asked  for review:
Bug 72893: [Qt][WK2] Add (experimental) viewport attributes view to
MiniBrowser/qt
https://bugs.webkit.org/show_bug.cgi?id=72893

Attachment 119018: Updated patch
https://bugs.webkit.org/attachment.cgi?id=119018&action=review

------- Additional Comments from Michael Brüning <michael.bruning at nokia.com>
Removed the caching of viewport constraint data in QWebViewportInfo and made it
use the QQuickWebViewPrivate data instead.
Added layoutSize as a member of QtViewportInteractionEngine::Constraints in
order to not cache it in QWebViewportInfo. 
Changed layoutWidth and layoutHeight to layoutSize and
contentsWidth/contentsHeight to contentsSize.


More information about the webkit-reviews mailing list