[webkit-reviews] review denied: [Bug 50999] Supports Unicode variation selector : [Attachment 118913] Patch (rebased to ToT)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 00:34:47 PST 2011

Nikolas Zimmermann <zimmermann at kde.org> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 50999: Supports Unicode variation selector

Attachment 118913: Patch (rebased to ToT)

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118913&action=review

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:470
> +void SimpleFontData::updateGlyphWithVariationSelector(UChar32 character,
UChar32 selector, Glyph& glyph) const

Hm, it should be possible to implement this in a cross platform fashion, no?
I'd rather prefer a platform specific method that gives you a Glyph for a pair
of UChar buffer and length.
This way updateGlyphWithVariationSelector could live in SimpleFontData

More information about the webkit-reviews mailing list