[webkit-reviews] review denied: [Bug 74040] Fails to build QtWebKit on QNX : [Attachment 118321] patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied ssukhyun at gmail.com's request
for review:
Bug 74040: Fails to build QtWebKit on QNX
https://bugs.webkit.org/show_bug.cgi?id=74040

Attachment 118321: patch
https://bugs.webkit.org/attachment.cgi?id=118321&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118321&action=review


> Source/JavaScriptCore/wtf/MathExtras.h:53
> +#if OS(QNX)
> +#include <math.h>
> +#endif

This was already fixed in r101041 by Daniel.

> Source/WebCore/platform/network/MIMESniffing.cpp:28
> +#if OS(QNX)
> +#include <string.h>
> +#endif

What about replacing #include <cstring> with #include <string.h> without any
#ifdef?