[webkit-reviews] review granted: [Bug 74048] A function of vector multiply with SSE optimization is needed in VectorMath.cpp : [Attachment 118951] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted xingnan.wang at intel.com's
request for review:
Bug 74048: A function of vector multiply with SSE optimization is needed in
VectorMath.cpp
https://bugs.webkit.org/show_bug.cgi?id=74048

Attachment 118951: Patch
https://bugs.webkit.org/attachment.cgi?id=118951&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118951&action=review


> Source/WebCore/platform/audio/VectorMath.cpp:278
> +#define SSE2_MULT(loadInstr, storeInstr)		      \
> +	       {					      \
> +		   pSource1 = _mm_load_ps(source1P);	      \
> +		   pSource2 = _mm_##loadInstr##_ps(source2P); \
> +		   dest = _mm_mul_ps(pSource1, pSource2);     \
> +		   _mm_##storeInstr##_ps(destP, dest);	      \
> +		   source1P += 4;			      \
> +		   source2P += 4;			      \
> +		   destP += 4;				      \
> +	       }
> +

You could even put the while  (destP < endP) in here.