[webkit-reviews] review denied: [Bug 74143] RenderTheme should have a function for disabled text color adjustment : [Attachment 118954] Patch 5 - Rebase
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 12 22:11:23 PST 2011
Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 74143: RenderTheme should have a function for disabled text color
adjustment
https://bugs.webkit.org/show_bug.cgi?id=74143
Attachment 118954: Patch 5 - Rebase
https://bugs.webkit.org/attachment.cgi?id=118954&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118954&action=review
> Source/WebCore/ChangeLog:16
> + * rendering/RenderTextControl.cpp:
> + (WebCore::RenderTextControl::adjustInnerTextStyle): Use
RenderTheme::disabledTextColor instead of PLATFORM wraped static function.
> + * rendering/RenderTheme.cpp:
> + (WebCore::RenderTheme::disabledTextColor): Moved from
RenderTextControl.cpp. This method implements for non-Chromium color.
> + * rendering/RenderTheme.h: Add new virtual method disabledTextColor.
> + * rendering/RenderThemeChromiumMac.h: Implementation of
RenderTheme::disabledTextColor for Chrimium Mac.
> + * rendering/RenderThemeChromiumSkia.h: Implementation of
RenderTheme::disabledTextColor for Chrimium.
Please update the file list.
More information about the webkit-reviews
mailing list