[webkit-reviews] review denied: [Bug 74228] Implement GLES2 CheckFramebufferStatus() behavior : [Attachment 118832] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 19:06:07 PST 2011

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 74228: Implement GLES2 CheckFramebufferStatus() behavior

Attachment 118832: Patch

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118832&action=review

This patch is missing the actual code changes. A couple of minor naming
convention issues as well.

> LayoutTests/fast/canvas/webgl/framebuffer-object-attachment.html:28
> +function CheckFramebufferForAllowedStatuses(allowedStatuses)

Naming convention: Check -> check

> LayoutTests/fast/canvas/webgl/framebuffer-object-attachment.html:235
> +function CheckFramebuffer(expected) {

Check -> check

More information about the webkit-reviews mailing list