[webkit-reviews] review granted: [Bug 74143] RenderTheme should have a function for disabled text color adjustment : [Attachment 118746] Patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 12 18:25:22 PST 2011
Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 74143: RenderTheme should have a function for disabled text color
adjustment
https://bugs.webkit.org/show_bug.cgi?id=74143
Attachment 118746: Patch 2
https://bugs.webkit.org/attachment.cgi?id=118746&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118746&action=review
> Source/WebCore/rendering/RenderThemeChromiumMac.h:35
> + virtual Color disabledTextColor(const Color& textColor, const Color&)
const OVERRIDE { return textColor; }
nit: This function can be private.
> Source/WebCore/rendering/RenderThemeChromiumSkia.h:61
> + virtual Color disabledTextColor(const Color& textColor, const
Color&) const OVERRIDE { return textColor; }
dito.
More information about the webkit-reviews
mailing list