[webkit-reviews] review granted: [Bug 71354] Resizing Cappuccino is very laggy on WebKit since Safari 5.1 : [Attachment 118921] Proposed patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 71354: Resizing Cappuccino is very laggy on WebKit since Safari 5.1
https://bugs.webkit.org/show_bug.cgi?id=71354

Attachment 118921: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=118921&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118921&action=review


>>> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:110
>>> +#else
>> 
>> Will a potentially stale value be used here as a result of this change? I'm
not even sure if any WindowAndViewFramesChanged will be delivered until after
the end of resizing.
> 
> What do you mean by the end of resizing? When you let go of the window edge?
On my (Lion) system, there's a steady stream of WindowAndViewFramesChanged
messages during resize. And this change does indeed make
<http://githubissues.heroku.com/> significantly less laggy.

I think it's absolutely fine to return a stale value here - the window between
resizing and the size being updated is small enough that it shouldn't matter in
practice. I think Chrome does something similar.