[webkit-reviews] review granted: [Bug 74359] WebAudio: Optimize AudioChannel::maxAbsValue(). : [Attachment 118892] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 16:47:48 PST 2011


Sam Weinig <sam at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 74359: WebAudio: Optimize AudioChannel::maxAbsValue().
https://bugs.webkit.org/show_bug.cgi?id=74359

Attachment 118892: Patch
https://bugs.webkit.org/attachment.cgi?id=118892&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118892&action=review


> Source/WebCore/platform/audio/VectorMath.cpp:85
> +void vmaxmgv(const float *sourceP, int sourceStride, float *dest, size_t
framesToProcess)

* on the wrong side.

> Source/WebCore/platform/audio/VectorMath.cpp:291
> +void vmaxmgv(const float *sourceP, int sourceStride, float *dest, size_t
framesToProcess)

* on the wrong side.

> Source/WebCore/platform/audio/VectorMath.h:39
> +void vmaxmgv(const float *sourceP, int sourceStride, float *dest, size_t
framesToProcess);

* on the wrong side.


More information about the webkit-reviews mailing list