[webkit-reviews] review denied: [Bug 74322] WebAudio: Use Logging instead of printf. : [Attachment 118897] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 16:45:55 PST 2011


Sam Weinig <sam at webkit.org> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 74322: WebAudio: Use Logging instead of printf.
https://bugs.webkit.org/show_bug.cgi?id=74322

Attachment 118897: Patch
https://bugs.webkit.org/attachment.cgi?id=118897&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118897&action=review


> Source/WebCore/webaudio/AudioContext.cpp:184
>  #if DEBUG_AUDIONODE_REFERENCES
> -    printf("%p: AudioContext::~AudioContext()\n", this);
> +    LOG(WebAudio, "%p: AudioContext::~AudioContext()\n", this);
>  #endif

If this is only for debugging, I don't think you should use printf.

> Source/WebCore/webaudio/AudioNode.cpp:314
>  void AudioNode::printNodeCounts()

Who calls this? If it is only for debugging (from a debugger) I think printf is
probably more idiomatic.

> Source/WebCore/webaudio/DefaultAudioDestinationNode.cpp:54
>  #ifndef NDEBUG    
> -    fprintf(stderr, ">>>> hardwareSampleRate = %f\n", hardwareSampleRate);
> +    LOG(WebAudio, ">>>> hardwareSampleRate = %f\n", hardwareSampleRate);
>  #endif

This #ifndef is no longer needed.


More information about the webkit-reviews mailing list