[webkit-reviews] review granted: [Bug 74338] Remove uses of JSFinalObject vptr : [Attachment 118861] Remove uses of JSFinalObject vptr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 15:02:30 PST 2011


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 74338: Remove uses of JSFinalObject vptr
https://bugs.webkit.org/show_bug.cgi?id=74338

Attachment 118861: Remove uses of JSFinalObject vptr
https://bugs.webkit.org/attachment.cgi?id=118861&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118861&action=review


r=me

> Source/JavaScriptCore/heap/MarkStack.cpp:310
> +    if (cell->classInfo() == &JSFinalObject::s_info) {

I'd create an isJSFinalObject() helper and use that here.


More information about the webkit-reviews mailing list