[webkit-reviews] review denied: [Bug 72682] iframe fails to scroll in composited page : [Attachment 118860] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 14:53:16 PST 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Adrienne Walker
<enne at google.com>'s request for review:
Bug 72682: iframe fails to scroll in composited page
https://bugs.webkit.org/show_bug.cgi?id=72682

Attachment 118860: Patch
https://bugs.webkit.org/attachment.cgi?id=118860&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118860&action=review


> Source/WebCore/page/FrameView.cpp:1548
> +	   LayoutRect rect(frameRenderer->borderLeft() +
frameRenderer->paddingLeft(),
> +			   frameRenderer->borderTop() +
frameRenderer->paddingTop(),
> +			   frameView->visibleWidth(),
frameView->visibleHeight());
> +	   frameRenderer->repaintRectangle(rect);

It's not clear that this rect math works correctly if there's a CSS transform
between this frame view and the one doing the repainting.


More information about the webkit-reviews mailing list