[webkit-reviews] review requested: [Bug 72871] Incorrect calculation for DistanceEffect linearGain : [Attachment 118813] Patch

[bugzilla-daemon at webkit.org]

Raymond Toy <rtoy at chromium.org> has asked  for review:
Bug 72871: Incorrect calculation for DistanceEffect linearGain
https://bugs.webkit.org/show_bug.cgi?id=72871

Attachment 118813: Patch
https://bugs.webkit.org/attachment.cgi?id=118813&action=review

------- Additional Comments from Raymond Toy <rtoy at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118813&action=review


>> Source/WebCore/ChangeLog:8
>> +	    No new tests. (OOPS!)
> 
> This line needs to be updated.  Either add a test for this, or say that tests
still must be written for all distance models.	This does not add new API.
> 
> (or something like that)

Updated.

>> Source/WebCore/platform/audio/Distance.cpp:74
>> +	// See Open AL 1.1 Specification, section 3.4.4.
> 
> If we include this comment, then we should include the URL and hoist it out
of this specific function and put it somewhere else more common, like the .h or
.idl

Moved to .h file.

>> Source/WebCore/platform/audio/Distance.cpp:77
>> +	distance = std::min(std::max(distance, m_refDistance), m_maxDistance);
> 
> This clamping is not specific to linearGain.	Also, this logic is already in
DistanceEffect::gain() which is taking into account m_isClamped so it should be
removed from here

Removed.