[webkit-reviews] review requested: [Bug 73852] Expose reusable WebSocket code for WebSocketServer. : [Attachment 118841] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 14:07:08 PST 2011

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 73852: Expose reusable WebSocket code for WebSocketServer.

Attachment 118841: Patch

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Thanks for having a look. I checked and I would still need a boolean flag in
buildFrameHeader to set the mask bit and append the making key. Here is a patch
that replaces the boolean flag by an option enum that contains all the flag bit
for the frame and use it in FrameData as well instead of individual booleans.

Another option would be to keep it that way and add an enum flag just for the
masking, or tell me if you have another idea.

More information about the webkit-reviews mailing list