[webkit-reviews] review denied: [Bug 74313] Implement the JavaScriptCore bindings for eventListenerHandlerLocation : [Attachment 118821] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 11:55:01 PST 2011


Geoffrey Garen <ggaren at apple.com> has denied Konrad Piascik
<kpiascik at rim.com>'s request for review:
Bug 74313: Implement the JavaScriptCore bindings for
eventListenerHandlerLocation
https://bugs.webkit.org/show_bug.cgi?id=74313

Attachment 118821: patch
https://bugs.webkit.org/attachment.cgi?id=118821&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118821&action=review


> Source/WebCore/bindings/js/ScriptEventListener.cpp:117
> +    if (!jsFunction && jsFunction->isHostFunction())

I think you meant "||" not  "&&".


More information about the webkit-reviews mailing list