[webkit-reviews] review denied: [Bug 74306] Fix Platform.h settings on non-IOS-simulator platforms : [Attachment 118808] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Andy Wingo
<wingo at igalia.com>'s request for review:
Bug 74306: Fix Platform.h settings on non-IOS-simulator platforms
https://bugs.webkit.org/show_bug.cgi?id=74306

Attachment 118808: Patch
https://bugs.webkit.org/attachment.cgi?id=118808&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118808&action=review


> Source/JavaScriptCore/wtf/Platform.h:595
>  #if PLATFORM(IOS_SIMULATOR)
> -    #define ENABLE_INTERPRETER 1
> -    #define ENABLE_JIT 0
> -    #define ENABLE_YARR 0
> -    #define ENABLE_YARR_JIT 0
> -#else
> -    #define ENABLE_INTERPRETER 1
> -    #define ENABLE_JIT 1
> -    #define ENABLE_YARR 1
> -    #define ENABLE_YARR_JIT 1
> +#define ENABLE_INTERPRETER 1
> +#define ENABLE_JIT 0
> +#define ENABLE_YARR 0
> +#define ENABLE_YARR_JIT 0
>  #endif

This whole block is inside a #if PLATFORM(IOS)/#endif macro pair.  How are
these macros being interpreted by other platforms?

Is there a mismatched #if/[#else/]#endif block above this?

> Source/JavaScriptCore/wtf/Platform.h:597
>  #endif

This is the end of the #if PLATFORM(IOS) macro.