[webkit-reviews] review granted: [Bug 74301] [EFL] Add API to notify that mixed content has been loaded. : [Attachment 118805] Move DocumentLoader.h include to bug 74302

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 74301: [EFL] Add API to notify that mixed content has been loaded.
https://bugs.webkit.org/show_bug.cgi?id=74301

Attachment 118805: Move DocumentLoader.h include to bug 74302
https://bugs.webkit.org/attachment.cgi?id=118805&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118805&action=review


OK, looks good, with just a nit.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1706
> +	   evas_object_smart_callback_call(ewkFrame, "mixedcontent,displayed",
0);
> +	   ewk_view_mixed_content_displayed_set(smartData->view, true);

Wouldn't it be more conceptually correct to first set it, and then emit the
signal? This way if the API user for some bizarre reason decides to query this
flag while handling the signal it'll be properly set.