[webkit-reviews] review granted: [Bug 74284] Bloom filter has unnecesary collisions : [Attachment 118772] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Allan Sandfeld
<sandfeld at kde.org>'s request for review:
Bug 74284: Bloom filter has unnecesary collisions
https://bugs.webkit.org/show_bug.cgi?id=74284

Attachment 118772: Patch
https://bugs.webkit.org/attachment.cgi?id=118772&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=118772&action=review


r=me, with a comment

> Source/WebCore/css/SelectorChecker.cpp:85
> +    identifierHashes.append(element->localName().impl()->existingHash() *
TagNameSalt);

It might consider adding an inline function for computing hash type from
AtomicString.