[webkit-reviews] review granted: [Bug 74208] Web Inspector: [Chromium] add support to inspector test suite to fetch test execution results from console : [Attachment 118622] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 74208: Web Inspector: [Chromium] add support to inspector test suite to
fetch test execution results from console
https://bugs.webkit.org/show_bug.cgi?id=74208

Attachment 118622: Patch
https://bugs.webkit.org/attachment.cgi?id=118622&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118622&action=review


>> Source/WebKit/chromium/src/js/Tests.js:561
>> +TestSuite.prototype.testWaitForResultsInConsole = function()
> 
> Could you elaborate on how you intend to use this?

Could you pick a more specific name for the test method?

> Source/WebKit/chromium/src/js/Tests.js:568
> +	   else if (/^FAIL/.test(text))

If there are several failures you may want to print all of them.