[webkit-reviews] review requested: [Bug 25913] single-file input elements should refuse multi-file drags : [Attachment 118761] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 03:10:04 PST 2011


Rakesh <rakesh.kn at motorola.com> has asked  for review:
Bug 25913: single-file input elements should refuse multi-file drags
https://bugs.webkit.org/show_bug.cgi?id=25913

Attachment 118761: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=118761&action=review

------- Additional Comments from Rakesh <rakesh.kn at motorola.com>
Refuse the multiple file drags on single-file input element. Setting the
dragSession.operation as DragOperationNone when input element is multiple and
number of files are more than 1. I think DragController::canProcessDrag may not
be the right place to refuse the drag as if canProcessDrag fails then
tryDocumentDrag will fail which may lead to the loading of the file in the
browser.


More information about the webkit-reviews mailing list