[webkit-reviews] review denied: [Bug 73957] Repaint video controls when buffering during pause. : [Attachment 118141] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 11 21:16:45 PST 2011

MORITA Hajime <morrita at google.com> has denied Dale Curtis
<dalecurtis at chromium.org>'s request for review:
Bug 73957: Repaint video controls when buffering during pause.

Attachment 118141: Patch

------- Additional Comments from MORITA Hajime <morrita at google.com>
> At least on Chromium, setting the position of MediaSliderThumb results in a
repaint for MediaSlider as well. Whether the repaint is done explicitly or is
just due to a change in HTMLMediaElement::percentLoaded() I'm not sure.
Your light, HTMLInputElement, which is a superclass of
MediaControlTimelineElement, should take care of it.

r- for now because the change doesn't contain test expectation file or
suppression lines.
Code looks good to me.

More information about the webkit-reviews mailing list