[webkit-reviews] review granted: [Bug 74257] [Refactoring] In prepare-ChangeLog, move top-level code to resolve conflicted ChangeLogs into a method : [Attachment 118716] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 74257: [Refactoring] In prepare-ChangeLog, move top-level code to resolve
conflicted ChangeLogs into a method
https://bugs.webkit.org/show_bug.cgi?id=74257

Attachment 118716: Patch
https://bugs.webkit.org/attachment.cgi?id=118716&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118716&action=review


> Tools/ChangeLog:13
> +	   * Scripts/prepare-ChangeLog: Moved top-level code to get the latest
ChangeLogs into getLatestChangeLogs(), and moved top-level code to resolve
conflicted ChangeLogs into resolveConflictedChangeLogs().

This line seems too long. Please add line breaks as needed.

> Tools/Scripts/prepare-ChangeLog:458
> +    if (@conflictedChangeLogs) {

It seems like we can exit early here.