[webkit-reviews] review granted: [Bug 74256] Move CSSElementStyleDeclaration to its own cpp/h files. : [Attachment 118709] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 11 12:41:06 PST 2011

Sam Weinig <sam at webkit.org> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 74256: Move CSSElementStyleDeclaration to its own cpp/h files.

Attachment 118709: Patch

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118709&action=review

>> Source/WebCore/css/CSSElementStyleDeclaration.cpp:27
>> +#include "CSSElementStyleDeclaration.h"
> You should add a blank line after implementation file's own header. 
[build/include_order] [4]

Do as the bot commands, add a blank line.

> Source/WebCore/css/CSSElementStyleDeclaration.h:35
> +class CSSElementStyleDeclaration : public CSSMutableStyleDeclaration {

It might be worth adding a comment about why this class exists, since only a
derived class can instantiate it.

More information about the webkit-reviews mailing list